afonin/PyAPNs2
1
0
Fork 0
Code Issues Wiki Activity

client.connect(): after error, close the connection

Browse Source 
Otherwise, the next self._connection.connect() call will not try again. In fact, it will do nothing. It won't raise the exception again.

Therefore, closing the connection before retrying is mandatory.
This commit is contained in:
Pavel Valach
2017-12-18 13:34:39 +03:00
committed by Sergey Petrov
parent a3244df06d
commit d3d75d1073
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apns2/client.py
+2
View File
@@ -183,6 +183,8 @@ class APNsClient(object):
logger.info('Connected to APNs') logger.info('Connected to APNs')
return return
except Exception: # pylint: disable=broad-except except Exception: # pylint: disable=broad-except
# close the connnection, otherwise next connect() call would do nothing
self._connection.close()
retries += 1 retries += 1
logger.exception('Failed connecting to APNs (attempt %s of %s)', retries, MAX_CONNECTION_RETRIES) logger.exception('Failed connecting to APNs (attempt %s of %s)', retries, MAX_CONNECTION_RETRIES)